Here is the error:

      [ 70%] No install step for 'download_ninja_source'
      [ 80%] Completed 'download_ninja_source'
      [ 80%] Built target download_ninja_source
      Scanning dependencies of target build_ninja
      [ 90%] Generating ../../../src/ninja
      ./src/disk_interface.cc: In member function 'virtual TimeStamp RealDiskInterface::Stat(const string&, std::__cxx11::string*) const':
      ./src/disk_interface.cc:219:51: error: 'struct stat' has no member named 'st_mtimensec'; did you mean 'st_mtim'?
         return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
                                                         ^~~~~~~~~~~~
                                                         st_mtim

I can provide the exact steps to reproduce. This looks like a bug, as things should compile. I think this is related to Alpine using musl instead of glibc.

The version released today fails when called like ninja --version and doesn't have a zero return code.

$ ninja --version
1.11.1.git.kitware.jobserver-1
$ echo $? 
245

This makes for example meson fail which calls ninja --version to detect the ninja version.

$ meson _build
The Meson build system
[...]
ERROR: Could not detect Ninja v1.8.2 or newer

This is on Ubuntu 22.04 using Python 3.10.7

This PR is for OS400 system support. Can anybody kindly help to review and merge it? thanks. "configure.py" is deprecated in ninja-build project, and it does not support OS400 system.

I made some similar changes as were necessary for cmake. I also updated the readme, to link to the correct Travis builds. After merging this PR, could you make a tag to upload a new release to pypi?

Pip installing ninja (via a setup dependency for a project relying on scikit-build to build) is failing because windows defender is blocking ninja.exe. It is flagging ninja.exe in the wheel as containing a trojan:

Originally submitted here: https://github.com/ninja-build/ninja/issues/1608

I believe that scikit-build should be added as a dependency in pip install as I get the following error if it is not installed:

$ pip install ninja
Collecting ninja
  Using cached https://files.pythonhosted.org/packages/dd/96/e2ec4acccb8dee33b4987f553d531d61e3081c8d4cfbce249655dfe23906/ninja-1.9.0.post1.tar.gz
    ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-av7tfuja/ninja/setup.py", line 7, in <module>
        from skbuild import setup
    ModuleNotFoundError: No module named 'skbuild'
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-av7tfuja/ninja/

Edit: System & platform information:

OS: Microsoft Windows 10 64-bit Python & pip info:

$ python --version
Python 3.7.4

$ python -c 'import sys; print("64-bit: {}".format(sys.maxsize > 2**32))'
64-bit: True

$ pip --version
pip 19.1 from /usr/lib/python3.7/site-packages/pip (python 3.7)

$ pip search ninja
ninja (1.9.0.post1)                               - Ninja is a small build
                                                    system with a focus on
                                                    speed
...

According to https://pypi.org/project/ninja/#history 1.9.0post1 (whatever that version might be) is the latest available version - are there any plans to dump a package to pypi soon?

I was referred here from https://github.com/ninja-build/ninja/issues/1754

tried to install ninja on a AWS ARM instance (a1.4xlarge). meson works fine, pip3 works fine, ninja fails. OS is ubuntu16. Probably also related to https://github.com/scikit-build/ninja-python-distributions/issues/27 also loading scikit-build and cmake before did not work. tnx.

sudo -H pip3 install scikit-build
sudo -H pip3 install "cmake==3.6.3"

sudo -H  pip3 install meson
Requirement already satisfied: meson in /usr/local/lib/python3.5/dist-packages (0.53.2)
---


 sudo -H pip3 install ninja
Collecting ninja
  Using cached ninja-1.9.0.post1.tar.gz (25 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-qwm9exys/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-qwm9exys/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-qwm9exys/ninja/pip-egg-info
         cwd: /tmp/pip-install-qwm9exys/ninja/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-qwm9exys/ninja/setup.py", line 7, in <module>
        from skbuild import setup
    ImportError: No module named 'skbuild'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.


----
sudo  pip3 install ninja
WARNING: The directory '/home/ubuntu/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting ninja
  Downloading ninja-1.9.0.post1.tar.gz (25 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-szjzp_04/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-szjzp_04/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-szjzp_04/ninja/pip-egg-info
         cwd: /tmp/pip-install-szjzp_04/ninja/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-szjzp_04/ninja/setup.py", line 7, in <module>
        from skbuild import setup
    ImportError: No module named 'skbuild'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
----
 pip3 install ninja
WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip.
Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue.
To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.
Defaulting to user installation because normal site-packages is not writeable
Collecting ninja
  Downloading ninja-1.9.0.post1.tar.gz (25 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-l7j_g1jq/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-l7j_g1jq/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-l7j_g1jq/ninja/pip-egg-info
         cwd: /tmp/pip-install-l7j_g1jq/ninja/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-l7j_g1jq/ninja/setup.py", line 7, in <module>
        from skbuild import setup
    ImportError: No module named 'skbuild'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

---
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.6 LTS
Release:        16.04
Codename:       xenial
---
 lscpu
Architecture:          aarch64
Byte Order:            Little Endian
CPU(s):                16
On-line CPU(s) list:   0-15
Thread(s) per core:    1
Core(s) per socket:    4
Socket(s):             4
NUMA node(s):          1
L1d cache:             32K
L1i cache:             48K
L2 cache:              2048K
NUMA node0 CPU(s):     0-15
---

after install of scikit-build

sudo -H pip3 install scikit-build

 sudo -H  pip3 install ninja
Collecting ninja
  Using cached ninja-1.9.0.post1.tar.gz (25 kB)
Building wheels for collected packages: ninja
  Building wheel for ninja (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-n6jnxwz2
       cwd: /tmp/pip-install-likc8w01/ninja/
  Complete output (82 lines):


  --------------------------------------------------------------------------------
  -- Trying "Ninja" generator
  --------------------------------
  ---------------------------
  ----------------------
  -----------------
  ------------
  -------
  --
  Not searching for unused variables given on the command line.
  CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
  -- Configuring incomplete, errors occurred!
  --
  -------
  ------------
  -----------------
  ----------------------
  ---------------------------
  --------------------------------
  -- Trying "Ninja" generator - failure
  --------------------------------------------------------------------------------



  --------------------------------------------------------------------------------
  -- Trying "Unix Makefiles" generator
  --------------------------------
  ---------------------------
  ----------------------
  -----------------
  ------------
  -------
  --
  Not searching for unused variables given on the command line.
  -- The C compiler identification is GNU 5.4.0
  -- Check for working C compiler: /usr/bin/cc
  -- Check for working C compiler: /usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- The CXX compiler identification is GNU 5.4.0
  -- Check for working CXX compiler: /usr/bin/c++
  -- Check for working CXX compiler: /usr/bin/c++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /tmp/pip-install-likc8w01/ninja/_cmake_test_compile/build
  --
  -------
  ------------
  -----------------
  ----------------------
  ---------------------------
  --------------------------------
  -- Trying "Unix Makefiles" generator - success
  --------------------------------------------------------------------------------

  CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
    CMake 3.6 or higher is required.  You are running version 3.5.1


  -- Configuring incomplete, errors occurred!
  Traceback (most recent call last):
    File "/usr/local/lib/python3.5/dist-packages/skbuild/setuptools_wrap.py", line 574, in setup
      languages=cmake_languages
    File "/usr/local/lib/python3.5/dist-packages/skbuild/cmaker.py", line 232, in configure
      os.path.abspath(CMAKE_BUILD_DIR())))

  An error occurred while configuring with CMake.
    Command:
      "cmake" "/tmp/pip-install-likc8w01/ninja" "-G" "Unix Makefiles" "-DCMAKE_INSTALL_PREFIX:PATH=/tmp/pip-install-likc8w01/ninja/_skbuild/linux-aarch64-3.5/cmake-install" "-DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3" "-DPYTHON_VERSION_STRING:STRING=3.5.2" "-DPYTHON_INCLUDE_DIR:PATH=/usr/include/python3.5m" "-DPYTHON_LIBRARY:FILEPATH=/usr/lib/aarch64-linux-gnu/libpython3.5m.so" "-DSKBUILD:BOOL=TRUE" "-DCMAKE_MODULE_PATH:PATH=/usr/local/lib/python3.5/dist-packages/skbuild/resources/cmake" "-DCMAKE_BUILD_TYPE:STRING=Release"
    Source directory:
      /tmp/pip-install-likc8w01/ninja
    Working directory:
      /tmp/pip-install-likc8w01/ninja/_skbuild/linux-aarch64-3.5/cmake-build
  Please see CMake's output for more information.
  ----------------------------------------
  ERROR: Failed building wheel for ninja
  Running setup.py clean for ninja
Failed to build ninja
Installing collected packages: ninja
    Running setup.py install for ninja ... error
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-ewi052c5/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.5/ninja
         cwd: /tmp/pip-install-likc8w01/ninja/
    Complete output (82 lines):


    --------------------------------------------------------------------------------
    -- Trying "Ninja" generator
    --------------------------------
    ---------------------------
    ----------------------
    -----------------
    ------------
    -------
    --
    Not searching for unused variables given on the command line.
    CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
    -- Configuring incomplete, errors occurred!
    --
    -------
    ------------
    -----------------
    ----------------------
    ---------------------------
    --------------------------------
    -- Trying "Ninja" generator - failure
    --------------------------------------------------------------------------------



    --------------------------------------------------------------------------------
    -- Trying "Unix Makefiles" generator
    --------------------------------
    ---------------------------
    ----------------------
    -----------------
    ------------
    -------
    --
    Not searching for unused variables given on the command line.
    -- The C compiler identification is GNU 5.4.0
    -- Check for working C compiler: /usr/bin/cc
    -- Check for working C compiler: /usr/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- The CXX compiler identification is GNU 5.4.0
    -- Check for working CXX compiler: /usr/bin/c++
    -- Check for working CXX compiler: /usr/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /tmp/pip-install-likc8w01/ninja/_cmake_test_compile/build
    --
    -------
    ------------
    -----------------
    ----------------------
    ---------------------------
    --------------------------------
    -- Trying "Unix Makefiles" generator - success
    --------------------------------------------------------------------------------

    CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
      CMake 3.6 or higher is required.  You are running version 3.5.1


    -- Configuring incomplete, errors occurred!
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/skbuild/setuptools_wrap.py", line 574, in setup
        languages=cmake_languages
      File "/usr/local/lib/python3.5/dist-packages/skbuild/cmaker.py", line 232, in configure
        os.path.abspath(CMAKE_BUILD_DIR())))

    An error occurred while configuring with CMake.
      Command:
        "cmake" "/tmp/pip-install-likc8w01/ninja" "-G" "Unix Makefiles" "-DCMAKE_INSTALL_PREFIX:PATH=/tmp/pip-install-likc8w01/ninja/_skbuild/linux-aarch64-3.5/cmake-install" "-DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3" "-DPYTHON_VERSION_STRING:STRING=3.5.2" "-DPYTHON_INCLUDE_DIR:PATH=/usr/include/python3.5m" "-DPYTHON_LIBRARY:FILEPATH=/usr/lib/aarch64-linux-gnu/libpython3.5m.so" "-DSKBUILD:BOOL=TRUE" "-DCMAKE_MODULE_PATH:PATH=/usr/local/lib/python3.5/dist-packages/skbuild/resources/cmake" "-DCMAKE_BUILD_TYPE:STRING=Release"
      Source directory:
        /tmp/pip-install-likc8w01/ninja
      Working directory:
        /tmp/pip-install-likc8w01/ninja/_skbuild/linux-aarch64-3.5/cmake-build
    Please see CMake's output for more information.
    ----------------------------------------
ERROR: Command errored out with exit status 1: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"'; __file__='"'"'/tmp/pip-install-likc8w01/ninja/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-ewi052c5/install-record.txt --single-version-externally-managed --compile --install-headers /usr/local/include/python3.5/ninja Check the logs for full command output.

To maintain backward compatibility with existing ninja wheels, this commit includes "ninja_syntax.py".

Suggested-by: Marat Dukhan [email protected]

This is just to force Appveyor CI to run again the same build as #10 to verify that the issue with cmake failing to find the MSBuild directory is fixed in latest cmake

See https://github.com/scikit-build/ninja-python-distributions/pull/10#issuecomment-378876147

I simply followed the instructions and run python scripts/update_ninja_version.py 1.8.2

It's weird that after installing ninja in a virtual environment one can invoke it with ./my_venv/bin/ninja but not also with ./my_venv/bin/python -m ninja.

ENVIRONMENT: Ubuntu 20.04 LTS

STEPS TO REPRODUCE:

1. python3.8 -m venv my_venv
2. ./my_venv/bin/python -m pip install --upgrade pip
3. ./my_venv/bin/python -m pip install --upgrade ninja
4. ./my_venv/bin/ninja --version
5. ./my_venv/bin/python -m ninja --version

EXPECTED RESULTS: I would expect that the ./my_venv/bin/python -m ninja --version execution would produce the same output as that produced by the ./my_venv/bin/ninja --version execution.

OBSERVED RESULTS: ./my_venv/bin/python -m ninja --version outputs /home/nathaniel/temp-temp/my_venv/bin/python: No module named ninja.__main__; 'ninja' is a package and cannot be directly executed.

updates:

• github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0
• github.com/PyCQA/isort: 5.10.1 → 5.11.4
• github.com/asottile/pyupgrade: v2.38.2 → v3.3.1
• github.com/PyCQA/flake8: 5.0.4 → 6.0.0

I'm trying to package this package as it is a dependency of meson-python. ninja-python-distributions tries to download a ninja source from the web. How can we avoid that and let it use a local version that?

Update documentation to indicate that the project doe not (yet) provide python-language programmatic access to ninja but contribution are welcome.

Worth noting that the project currently package ninja_syntax.py already provided by the upstream project. See https://github.com/ninja-build/ninja/tree/master/misc

See https://github.com/scikit-build/ninja-python-distributions/issues/36#issuecomment-688392362