I've been enjoying your library, it has some of the better implementations in an easy to implement way (ex. _methods)

One thing I've noticed is that you have specified that your requirements are all static (requests/urllib for example).

Because your implementation of those requirements are not really integrated into your library, would it not make more sense to create a major version upper limit?

my rec:

requests~=2.26
urllib3~=1.26

Im of course ready to be corrected on this.

It looks like issue #21 mentions that you wanted to use __slots__ in this project. I'm not familiar with the structure of the project or where all the classes are defined, so this PR only adds __slots__ for the one class that had the todo comment for it.

All of the rest of the classes should be just as simple. You just have to list out all of the expected instance attributes for each class. If a class is simple and just assigns all of it's attributes normally with self.<name> = ... in it's __init__ or elsewhere, then you can just search for self.\w+ = to locate names easily.

Using __slots__ instead of the default __dict__ for attributes is pretty straightforward unless you have classes where instance attributes are dynamically set (not just appear to be set with a __getattr__ or __getattribute__ that intercepts attribute access).

I'm not sure this change warrants any extra tests since the existing test suite covers all of the attribute assignments in the tag class

$ coverage run -m unittest discover tests
<lots of output, enough lines with just hi to fill up my entire terminal history>
...
----------------------------------------------------------------------
Ran 259 tests in 19.748s

OK
$ coverage report -m | grep html
Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
domonic/html.py                                                                       294     45    85%   65-66, 72-78, 103-104, 121-122, 130-131, 155-158, 169-172, 178-181, 187-190, 194-196, 225-227, 265, 272, 322, 487, 490, 493, 512, 515
tests/test_html.py                                                                     77     25    68%   47-56, 60-91, 95-133, 137-358, 362-532, 537-805, 845

In HTML5, there are a number of boolean attributes, e.g. async, checked and disabled. It would be nice if these could be recognized and simply output as their short form. Currently, as a workaround, you can give them an empty string or their own name as value, e.g.

_script(_src="foo.js", _async="async")

gives

<script src="foo.js" async="async"/>

but would be nice if we could have

<script src="foo.js" async/>

When instantiating a domonic.html.comment (or a dom.Comment, same same) object in a Sanic response, I'm getting the exception unable to update parent 'Comment' object has no attribute 'args' (from dom.py line 193) seven to eleven times in my log. I can't reproduce it in a REPL session. I also can't figure out why I get any particular number of exceptions, but they are the same number from page load to page load.

@app.route("/test_comment")
async def test_comment(req):
    return response.html(f"{html(head(), body(comment('foo')))}")

[2021-10-11 12:39:04 +0200] [9197] [INFO] Starting worker [9197]
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
unable to update parent 'Comment' object has no attribute 'args'
[2021-10-11 12:39:15 +0200] [9197] [DEBUG] KeepAlive Timeout. Closing connection.

When converting the html object with str and returning it as a response, closing tags for void elements like meta are correctly omitted.

When converting it in an f-string and returning it as a response, closing tags are erroneously included. Example of a simple Sanic route:

@app.route("/404.html")
async def not_found(req: request.Request) -> response.HTTPResponse:
    four_oh_four = html(
        head(
            meta(_charset="utf-8")
        ),
        body(
            h1("Page Not Found"),
            p("Sorry, but the page you were trying to view does not exist."),
        ),
        _lang="en"
    )
    return response.html(f"{four_oh_four}")

which generates the following HTML:

<!DOCTYPE html>
<html lang="en">
	<head>
		<meta charset="utf-8">
		</meta>
	</head>
	<body>
		<h1>Page Not Found</h1>
		<p>Sorry, but the page you were trying to view does not exist.</p>
	</body>
</html>

Note the errant </meta> on line 5. For comparison, the output with return response.html(str(four_oh_four)) is

<html lang="en"><head><meta charset="utf-8" /></head><body><h1>Page Not Found</h1><p>Sorry, but the page you were trying to view does not exist.</p></body></html>

but then I don't get the doctype element.

currently missing decent setTimout and clearTimeout methods.

I'd like these to work 2 ways. async and not. so a flag needs to be added to make async=True. currently i doubled up and 2 new ones to 'Global' so the old implementations could be left alone. (not that they worked. its just a sleep.)

ideally somehow utilise the SetInterval work that was done in the past. I had avoided ayncio due to api changes between python versions. I'd get setInterval to work in one version but it would fail in another so went to 'threads' for the Job class. howeer this is only async atm. should it block during exec?

for now I can't see me getting to this for a while. so making a ticket not to use setTimeout and clearTimeout as they aren't done. But will be once I get time and can think about how I resolve these issues.

Howdy. There seems to be some issue rendering the href tag, at least in <a> tags. If you include query parameters it cuts off the link past the ?, if you include https://. See below.

Note, the link does work if put into resulting html correctly (meaning, with the query).

from domonic import a, render

if __name__ == "__main__":

    urls = [
      'example.com/stuff?things=morestuff',
      'https://example.com/stuff?things=morestuff',
      'https://example.com/stuff',
      'https://www.example.com/stuff?thing',
      'https://www.example.com/?stuff'
    ]

    for url in urls:
        print(
            f'''
---------
Renders as: {render(a(_href=url))}
 should be: <a href="{url}"></a>
---------'''
        )

results in the following:

---------
Renders as: <a href="example.com/stuff?things=morestuff"></a>
 should be: <a href="example.com/stuff?things=morestuff"></a>
---------

---------
Renders as: <a href="https://example.com/stuff"></a>
 should be: <a href="https://example.com/stuff?things=morestuff"></a>
---------

---------
Renders as: <a href="https://example.com/stuff"></a>
 should be: <a href="https://example.com/stuff?thing"></a>
---------

---------
Renders as: <a href="https://www.example.com/stuff"></a>
 should be: <a href="https://www.example.com/stuff?thing"></a>
---------

---------
Renders as: <a href="https://www.example.com/"></a>
 should be: <a href="https://www.example.com/?stuff"></a>
---------

porting d3 polygon across:

reference... https://github.com/d3/d3-polygon

@FrackOverflow - if you want you can assign this to yourself. free free to make tickets also if you see anything else you want to take on.

This should be a working implementation for setTimeout and clearTimeout as mentioned in #11.

I'm not familiar enough with the project to know how to integrate it with SetInterval mentioned in the issue, but threading.Timer is a python builtin that provides pretty much exactly the same functionality as setTimeout and clearTimeout does in javascript.

I've also added two tests for this. One that checks that the callback is actually called, and the other that checks that a callback can be canceled properly.

we have a new replacement method that can do complex css queries but for some reason it doesn't do simple ones i.e. single tags. so they needed to be merged however an issue arose as the new one used getElementByID which was using querySelctor. fuck. So I losts a ton of fucking time and broke a branch (that had my an attempt at dict setters for attribs in it). anyways. will have another attempts at merging these together to work properly again another time. Or unless someone really really complains.

Bumps ujson from 4.0.2 to 5.1.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps sanic from 22.3.2 to 22.6.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps ujson from 5.2.0 to 5.4.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hi, I'm trying to get a handle on domonic.html module via import domonic.html or from domonic import html as opposed to from domonic.html import * (to be able to do html.span("hello") instead of span("hello")). However, domonic.html is ambiguous with the value "html" that gets imported in domonic/__init__.py . I think the star import there is responsible but I'm no expert. Given that import, all of html's exports are accessible by dom; i.e. you can write dom.span("html") which would seem to accomplish my needs but I don't think was intended in the design of these modules; that is I can confusingly write import domonic as html when I want import domonic.html.

Tile was unfinished but ended up in the repo.

@FrackOverflow If you enjoyed fixing my polygon d3 has a tons of fun stuff. i.e d3 - heirachy

and some real beauties if you dig around. i.e. https://github.com/d3/d3-plugins/tree/master/superformula

FYI my reason for porting d3 was to create 'real world' test cases for the use of Javascript.py class in domonic.

Just so you know it was mainly done to help me evolved the Javascript class. It makes it useful for quickly porting stuff. But ideally we'd do it all in proper python as swap out the js-like useage. Just incase you wonder why the code in the d3 section in strange.

While answering a question on stackoverflow today i realised that domonics mutationobserver is still commented out as TODO but also querySelectorAll is supposed to be 'not live'...

https://stackoverflow.com/questions/69975232/track-changes-within-dom-element-with-mutationobserver-python/69987634?noredirect=1#comment123721040_69987634

I have a feeling ours will be live. so should be returning node copies instead? It may not be and passing by value so I'll have to check.

If anyone is keen to dev this bit up then take it away. Otherwise will leave as a ticket for now til i get time.