Redeem code has change retcode form -2003 to -2004 and add -2016 is Redemption in cooldown

[-2004] Invalid redemption code. [-2016] Redemption in cooldown.

Trying to create a new GenshinClient instance with an authkey fails with the error authkey must have precisely 1024 characters. Trying to set the authkey on an existing instance results in the same error. The auth key I'm providing is longer than 1024 characters. The base64 decoded auth key, however, is exactly 1024 characters long. Providing that instead of the base64 encoded one results in a different error: authkey is not a valid base64 encoded string

The ch server fully uses the v2 version of the cookies

ltoken_v2=xxxx
ltmid_v2=xxx
cookie_token_v2=xxxx
account_mid_v2=xxxxx

It is not possible to get the user id from account_mid_v2 because it is a random string character generated by the ch server. https://github.com/thesadru/genshin.py/blob/dbebc29f485f01e352e75c6e389e754369101a9c/genshin/client/manager/managers.py#L238-L248

Some endpoint block some IP address, add a aiohttp proxy setting to client.

https://docs.aiohttp.org/en/stable/client_advanced.html

Hoyolab(oversea) block Chinese IP, a http proxy can help😀

Does Hoyoverse remove the Hoyolab check in API? I still use genshinstats but when I use Hoyolab check in it throw an error genshinstats.errors.GenshinStatsException: Internal database error, see original message, did they remove it now?

Since honkai has its own daily sign-in rewards it'd be nice to support it in genshin.py.

The logic is the exact same, only the base url and act id differ. The biggest problem is figuring out how to properly implement it without much repetition.

Currently, users can use:

class HonkaiClient(GenshinClient):
    ACT_ID = "e202110291205111"
    REWARD_URL = "https://api-os-takumi.mihoyo.com/event/mani/"

client = HonkaiClient(...)
client.claim_daily_reward()

How to reproduce ? Using CLI to login after that invoke python -m genshin accounts --cookies "ltoken=...; ltuid=..."

Current behavior It's just display error which state:

genshin.errors.InvalidCookies: [-100] Cookies are not valid.

As the title suggests, attempting to use client.get_notes({uidOfSomeoneElse}) on another user that has a publicly open battle chronicle returns this exception. Is this because Hoyolab doesn't allow you to get notes for other users? If that's the case, the description "Tried to use a beta feature in an invalid context." doesn't sound correct (unless this is a beta feature that's actually being worked on, in that case go you!).

I'm not too familiar with the actual API endpoint myself, but it seems the current implementation defaults to 1 region only? (I'm guessing at the mercy of the default returned values from the API endpoint)

Obtaining this exception when trying to retrieve the genshin characters from the API. It's due to Nilou's ID not being in the internal database.

Traceback (most recent call last):
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\discord\ext\tasks\__init__.py", line 239, in _loop
    await self.coro(*args, **kwargs)
  File "c:\Users\ElRey\Documents\Scripts\Python\ReyBot\discord_tools\tasks.py", line 10, in updateGenshinChars    
    chars = await client.get_genshin_characters(cfg.genshin_data["uuid"])
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\components\chronicle\genshin.py", line 78, in get_genshin_characters
    data = await self._request_genshin_record("character", uid, lang=lang, method="POST")
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\components\chronicle\genshin.py", line 51, in _request_genshin_record
    return await self.request_game_record(
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\components\chronicle\base.py", line 63, in request_game_record
    data = await self.request_hoyolab(url, lang=lang, region=region, **kwargs)
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\components\base.py", line 380, in request_hoyolab
    data = await self.request(url, method=method, params=params, data=data, headers=headers, **kwargs)
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\components\base.py", line 294, in request
    response = await self.cookie_manager.request(
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\manager.py", line 243, in request
    return await self._request(method, url, cookies=self.cookies, **kwargs)
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\ratelimit.py", line 24, in inner
    x = await func(*args, **kwargs)
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\client\manager.py", line 137, in _request
    errors.raise_for_retcode(data)
  File "C:\Users\ElRey\AppData\Local\Programs\Python\Python310\lib\site-packages\genshin\errors.py", line 224, in raise_for_retcode
    raise exctype(data, msg)
genshin.errors.InternalDatabaseError: [-1] character id:10000070 is not exists

i want to try wish history but i got this error TypeError: 'MergedPaginator' object is not iterable

this is my code

import asyncio
import genshin
cookies = {"ltuid": xxxxxxxx, "ltoken": "xxxxxxxxxxxxxx"}
client = genshin.Client(cookies)

async def main():
    for wish in client.wish_history():
        print(f"{wish.time} - {wish.name} ({wish.rarity}* {wish.type})")

asyncio.run(main())

if my coding is wrong I'm sorry, I'm just learning to use python

It would be ideal if there was an alternative source that reliably had the newest information. This is currently ambr but it would be better if we could have some alternative on hand like GenshinData. The current forks seem a bit unviable.

Currently we're using version 2.11.1, way lower behind the live production ds version 2.40.

Some related code:

https://github.com/y1ndan/genshinhelper2/blob/5402ffbe76885432d387e3cf04bb9d1dcefb9075/genshinhelper/utils.py#L163-L202 https://github.com/Le-niao/Yunzai-Bot/blob/07f39c89bd2603b447ba924aea43e55c2b6d6549/plugins/genshin/model/mys/mysApi.js#L230-L307

Looks like we also need to send full headers to daily reward endpoint, but there's some problem:

1. x-rpc-device_id value only obtainable in daily reward requests made by official client, kinda hard to get it unless everyone know how to use mitm proxy.
2. Also x-rpc-device_model/x-rpc-device_name, I don't expect that many user know their correct device modal/name string.
3. It isn't really user-friendly if some value aren't obtainable unless u install a mitm proxy.
4. Does the daily reward requires separate ds salt value?

Pydantic is great and all but it's incredibly limiting for validation. (see the custom model that has to be used).

This should either be decoupled into a separate library or at least cleaned up. Considering dropping re-serialization for optimization.

Possibilities:

• mkdocs material for guide and pdoc for API (ugly)
• mkdocs material for guide and sphinx for API (confusing)
• sphinx for guide and API (limiting)