We (our team) were trying with your library, and stumbled on this "missing" feature.

It's important to close the connections for a truly graceful shutdown. Was that a project decision? Didn't you just think about it?

More important: would you be willing to receive a proposal for this implementation?

redis_url setting is currently ignored and DSN is always built by using separate parameters

This is just a PoC, I will provide a more thorough PR in the next days

Hi, I noticed this project uses __all__ for most of its modules. However, in fastapi_plugins/__init__.py I see __all__ = [] which causes my editor to warn with things like 'RedisSettings' is not declared in __all__. I decided to simply remove __all__ from there since it is optional. Alternatively, I could combine __all__ from each of the imported modules.

What do you think?

Pytest API testing does not work if a function has a cache dependency.

Here is the example

@router.post("/login/", response_model=Token)
async def login(form_data: OAuth2PasswordRequestForm = Depends(),
                cache: aioredis.Redis = Depends(fastapi_plugins.depends_redis)):
                ...
                await cache.setex("SomeKey", 300, "SomeValue")

    @pytest.mark.asyncio
    async def test_login_view_pass(self, client):
        data = UserInput(**self.__generate_data())
        await user_create(data)
        response = await client.post(f"{settings.API_VERSION}/users/login/",
                                     data={"username": data.username,
                                           "password": data.password},
                                     headers={"Content-Type": "application/x-www-form-urlencoded"})
        assert response.status_code == status.HTTP_200_OK

self = <starlette.datastructures.State object at 0x7f10ceccd610>, key = 'REDIS'

    def __getattr__(self, key: typing.Any) -> typing.Any:
        try:
            return self._state[key]
        except KeyError:
            message = "'{}' object has no attribute '{}'"
>           raise AttributeError(message.format(self.__class__.__name__, key))
E           AttributeError: 'State' object has no attribute 'REDIS'

/usr/local/lib/python3.8/site-packages/starlette/datastructures.py:672: AttributeError

Is there any way to solve this issue ?

aioredis does not import anymore create_redis_pool method in its __init__ at least after v1.3.1 see here.

Unfortunately fastapi-plugins is still using that method in _redis.init() and it defines aioredis>=1.3.* in its setup.py see here

That can cause to raise the following exception in case aioredis > 1.3.1 has been installed in your system

AttributeError: module 'aioredis' has no attribute 'create_redis_pool'

I test fastapi-plugins using the example codes ,but it corrupts with

fastapi.exceptions.FastAPIError: Invalid args for response field! 
Hint: check that <class 'starlette.requests.HTTPConnection'> is a valid pydantic field type

the codes all go here

import fastapi, fastapi_plugins
import aioredis, pydantic, typing

@fastapi_plugins.registered_configuration
class AppSettings(
        fastapi_plugins.ControlSettings,
        fastapi_plugins.RedisSettings,
        fastapi_plugins.SchedulerSettings
):
    api_name: str = str(__name__)


app = fastapi.FastAPI()
config = fastapi_plugins.get_config()

@app.get("/")
async def root_get(
        cache: aioredis.Redis=fastapi.Depends(fastapi_plugins.depends_redis), # TODO corrupts here,
        conf: pydantic.BaseSettings=fastapi.Depends(fastapi_plugins.depends_config) # noqa E501
) -> typing.Dict:
    return dict(ping=await cache.ping(), api_name=conf.api_name)

@app.on_event('startup')
async def on_startup() -> None:
    await fastapi_plugins.config_plugin.init_app(app, config)
    await fastapi_plugins.config_plugin.init()
    await fastapi_plugins.redis_plugin.init_app(app, config=config)
    await fastapi_plugins.redis_plugin.init()
    await fastapi_plugins.scheduler_plugin.init_app(app=app, config=config)
    await fastapi_plugins.scheduler_plugin.init()
    await fastapi_plugins.control_plugin.init_app(app, config=config, version="0.0.1", environ=config.dict())
    await fastapi_plugins.control_plugin.init()


@app.on_event('shutdown')
async def on_shutdown() -> None:
    await fastapi_plugins.control_plugin.terminate()
    await fastapi_plugins.scheduler_plugin.terminate()
    await fastapi_plugins.redis_plugin.terminate()
    await fastapi_plugins.config_plugin.terminate()

packages info:

pip show fastapi-plugins
#Name: fastapi-plugins
#Version: 0.8.1

pip show fastapi
#Name: fastapi
#Version: 0.54.2

what have I missed?